Ruby on Rails Code Quality Checklist

matthewpaulmoore.com — Practices your development team needs to adhere by

1 Comments

smeade, on 11/11/2008, -0/+0Thanks for the checklist. Well done. I'll keep it handy to review my own work.

I'll pass on the "never use STI" check item though. What's the problem in this: http://www.martinfowler.com/eaaCatalog/singleTable ... again? Using Fowler's example, if I want a list of all Players, it's nice and simple to have a Player model to pull from, a Player index action to execute, and a players route to call. You could create a Players controller that manually merges data from Footballer and Cricketer. But then you're hitting two tables and adding unnecessary lines of code that couple Footballer and Cricketer in a more fragile way than using STI does. I see leveraging Rails STI support as an example of both RESTful practice and convention over configuration.

Maybe you could explain a little more. Is it inheritance you have an issue with or STI as Rails' implementation of inheritance?

Scott Meade
Add a Comment

Login or register to comment!
Or, sign-in super fast with your Facebook account ...